MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

WIP: Added a new window for shortcut configuration #607

Closed
Goodfeat wants to merge 22 commits from master into master
pull from: master
merge into: MeloNX:master
Conversation 7 Commits 22 Files Changed 10 +3 -8
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3a8737f0e6 - Show all commits

11
src/Ryujinx/UI/Windows/ArgumentsConfigWindows.axaml.cs
View File

@ -82,11 +82,12 @@ namespace Ryujinx.Ava.UI.Windows
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GameName, GameName,
GameId, GameId,
GameIconData, GameIconData,
SetArguments() GetArguments()
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
); );
} }
private string SetArguments() { private string GetArguments()
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
string line = ""; string line = "";
@ -155,12 +156,6 @@ namespace Ryujinx.Ava.UI.Windows
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
protected override void OnClosing(WindowClosingEventArgs e) protected override void OnClosing(WindowClosingEventArgs e)
{ {
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
foreach (IGamepad gamepad in RyujinxApp.MainWindow.InputManager.GamepadDriver.GetGamepads())
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
{
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
gamepad?.ClearLed();
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
}
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
base.OnClosing(e); base.OnClosing(e);
} }
} }

GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:56:19 +00:00 (Migrated from github.com)
Review
Copy Link

I don't think the LED clearing logic is needed here

I don't think the LED clearing logic is needed here
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything
GreemDev commented 2025-02-01 06:57:12 +00:00 (Migrated from github.com)
Review
Copy Link

Drop the brace into a new line; rename the method to GetArguments; it is returning a value and not setting anything

Drop the brace into a new line; rename the method to `GetArguments`; it is returning a value and not setting anything