MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Motion controls mainly for Windows handhelds #610

Open
SomeoneIsWorking wants to merge 1 commits from SomeoneIsWorking/feat/sdl3-handheld-gyro into master
pull from: SomeoneIsWorking/feat/sdl3-handheld-gyro
merge into: MeloNX:master
Conversation 2 Commits 1 Files Changed 18 +216 -10
SomeoneIsWorking commented 2025-02-01 13:01:24 +00:00 (Migrated from github.com)
Copy Link

What is this: Motion input for devices such as ASUS ROG Ally without emulating another type of controller.
How it works: Using SDL3 device sensors instead of relying on controller sensors.
Does it work: Well... It's not perfect. The aiming is a bit off but for example for games that use flick motions (ie: hat throwing), it should cover all your needs.

Alternatively I was in the process of making a separate software using SDL3 that works as a CemuHook emitter but it's not done.
I failed the first time then decided to borrow CemuHook code from Ryujinx to handle the protocols but never got around to finishing it.

The "previous" Ryujinx staff decided against merging this because this makes the project use both SDL2 and SDL3 which is not ideal and also SDL3 wasn't fully released yet.

I decided to open this PR not with the goal of getting it merged but if there is anyone interested in it then they will know there is some work towards this and they can download this, play around, maybe got it working better, not sure.

What is this: Motion input for devices such as ASUS ROG Ally without emulating another type of controller. How it works: Using SDL3 device sensors instead of relying on controller sensors. Does it work: Well... It's not perfect. The aiming is a bit off but for example for games that use flick motions (ie: hat throwing), it should cover all your needs. Alternatively I was in the process of making a separate software using SDL3 that works as a CemuHook emitter but it's not done. I failed the first time then decided to borrow CemuHook code from Ryujinx to handle the protocols but never got around to finishing it. The "previous" Ryujinx staff decided against merging this because this makes the project use both SDL2 and SDL3 which is not ideal and also SDL3 wasn't fully released yet. I decided to open this PR not with the goal of getting it merged but if there is anyone interested in it then they will know there is some work towards this and they can download this, play around, maybe got it working better, not sure.
👍 2
github-actions[bot] commented 2025-02-01 16:46:22 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+0705505-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525300218.zip) * [ryujinx-Release-1.2.0+0705505-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525300311.zip) * [ryujinx-Release-1.2.0+0705505-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525304855.zip) * [ryujinx-Release-1.2.0+0705505-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525305127.zip) * [ryujinx-Release-1.2.0+0705505-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525305192.zip) * [ryujinx-Release-1.2.0+0705505-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525316416.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+0705505-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525304917.zip) * [ryujinx-Debug-1.2.0+0705505-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525305045.zip) * [ryujinx-Debug-1.2.0+0705505-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525305545.zip) * [ryujinx-Debug-1.2.0+0705505-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525307075.zip) * [ryujinx-Debug-1.2.0+0705505-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525307198.zip) * [ryujinx-Debug-1.2.0+0705505-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2525317967.zip) </details>
GreemDev commented 2025-02-01 16:47:40 +00:00 (Migrated from github.com)
Copy Link

I'd prefer if this is delayed until we properly support only SDL3.

Much like the original team, I am very much against relying on 2 different versions of the same library; especially when it's not needed and one of the SDLs is used for a niche purpose (such as allowing motion on handhelds)

2 different SDLs, as a result, 2 SDL DLLs (or .SO or .dylib) exist in the result app folder; one of which for an insanely niche use, is not great.

I'd prefer if this is delayed until we properly support *only* SDL3. Much like the original team, I am very much against relying on 2 different versions of the same library; especially when it's not *needed* and one of the SDLs is used for a niche purpose (such as allowing motion on handhelds) 2 different SDLs, as a result, 2 SDL DLLs (or .SO or .dylib) exist in the result app folder; one of which for an insanely niche use, is not great.
👍 1
This pull request has changes conflicting with the target branch.
  • Ryujinx.sln
  • src/Ryujinx/UI/Views/Input/MotionInputView.axaml.cs
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin SomeoneIsWorking/feat/sdl3-handheld-gyro:SomeoneIsWorking/feat/sdl3-handheld-gyro
git checkout SomeoneIsWorking/feat/sdl3-handheld-gyro
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
infra
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#610
No description provided.
Delete Branch "SomeoneIsWorking/feat/sdl3-handheld-gyro"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?