MeloNX/Ryujinx-ryubing
11
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

WIP: Make the uPNP device search more reliable for LDN #641

Closed
Vudjun wants to merge 2 commits from upnp-fix into master
pull from: upnp-fix
merge into: MeloNX:master
Conversation 6 Commits 2 Files Changed 1 +44 -21
Vudjun commented 2025-02-08 18:42:33 +00:00 (Migrated from github.com)
Copy Link

Fixes where uPNP was failing due to it attempting to use the wrong network device.

It will now attempt to use each network device in turn until it succeeds.
This also adds more debug output to help figure out the cause of uPNP issues.
Needs testing from people who get the "Failed to open a port with UPnP for P2P connection." error.

Fixes where uPNP was failing due to it attempting to use the wrong network device. It will now attempt to use each network device in turn until it succeeds. This also adds more debug output to help figure out the cause of uPNP issues. Needs testing from people who get the "Failed to open a port with UPnP for P2P connection." error.
FluffyOMC commented 2025-02-08 18:45:48 +00:00 (Migrated from github.com)
Copy Link

Should probably add a uh, ahem

Fixes #639

Oh, nvm... You didn't add it @w@;

Should probably add a uh, ahem Fixes #639 Oh, nvm... You didn't add it @w@;
Vudjun commented 2025-02-08 18:47:48 +00:00 (Migrated from github.com)
Copy Link

Should probably add a uh, ahem

Fixes #639

Oh, nvm... You didn't add it @w@;

I don't know if it fixes it, that could be a separate issue as firewall rules weren't making a difference for me

> Should probably add a uh, ahem > > Fixes #639 > > Oh, nvm... You didn't add it @w@; I don't know if it fixes it, that could be a separate issue as firewall rules weren't making a difference for me
github-actions[bot] commented 2025-02-08 18:51:13 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+d7375f4-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559424610.zip) * [ryujinx-Release-1.2.0+d7375f4-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559424654.zip) * [ryujinx-Release-1.2.0+d7375f4-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559426476.zip) * [ryujinx-Release-1.2.0+d7375f4-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559426508.zip) * [ryujinx-Release-1.2.0+d7375f4-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559427194.zip) * [ryujinx-Release-1.2.0+d7375f4-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559430671.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+d7375f4-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559424831.zip) * [ryujinx-Debug-1.2.0+d7375f4-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559424876.zip) * [ryujinx-Debug-1.2.0+d7375f4-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559426765.zip) * [ryujinx-Debug-1.2.0+d7375f4-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559427197.zip) * [ryujinx-Debug-1.2.0+d7375f4-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559427269.zip) * [ryujinx-Debug-1.2.0+d7375f4-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2559432885.zip) </details>
FluffyOMC commented 2025-02-08 18:51:29 +00:00 (Migrated from github.com)
Copy Link

Should probably add a uh, ahem
Fixes #639
Oh, nvm... You didn't add it @w@;

I don't know if it fixes it, that could be a separate issue as firewall rules weren't making a difference for me

I mean, it took Mr. Food ( a person on discord) from failing to UPnP 6 times in a row, to just 2 fails, 1 working... Which was the same result for me. So I feel like this could be quite 50/50 lol-

> > Should probably add a uh, ahem > > Fixes #639 > > Oh, nvm... You didn't add it @w@; > > I don't know if it fixes it, that could be a separate issue as firewall rules weren't making a difference for me I mean, it took Mr. Food ( a person on discord) from failing to UPnP 6 times in a row, to just 2 fails, 1 working... Which was the same result for me. So I feel like this could be quite 50/50 lol-
Vudjun commented 2025-02-14 20:56:23 +00:00 (Migrated from github.com)
Copy Link

Closing this for now as the fix hasn't worked for anyone other than me, @FluffyOMC found this issue in OpenNAT as the probable root cause
https://github.com/lontivero/Open.NAT/issues/100
for now you can disable IPv6 on your network interface (possibly also on your router?) as a workaround.

Closing this for now as the fix hasn't worked for anyone other than me, @FluffyOMC found this issue in OpenNAT as the probable root cause https://github.com/lontivero/Open.NAT/issues/100 for now you can disable IPv6 on your network interface (possibly also on your router?) as a workaround.
FluffyOMC commented 2025-02-14 22:16:05 +00:00 (Migrated from github.com)
Copy Link

For now, we can either go to a different dependency for TCP, or just finish making everything UDP.

For now, we can either go to a different dependency for TCP, or just finish making everything UDP.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
horizon
ldn
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
0-Blu Fen Lonkelle Propenchieferr Stern bella jkcoxson june ny spidy123222 stossy11
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#641
No description provided.
Delete Branch "upnp-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?