MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Improved interaction with "Input" settings. #708

Open
Goodfeat wants to merge 27 commits from Goodfeat/Master_PR into master
pull from: Goodfeat/Master_PR
merge into: MeloNX:master
Conversation 5 Commits 27 Files Changed 13 +508 -83
Goodfeat commented 2025-02-23 00:23:49 +00:00 (Migrated from github.com)
Copy Link

I made some fixes to the settings input section.

Changes and fixes:

  • Paired devices have notifications that they are configured and require connection
  • Paired devices load the configuration when connected
  • Disconnected but configured controllers wait for connection, displaying the name and device ID.
  • A notification appears when changing control configuration settings.
  • Now control settings will be saved only when they are changed **
  • Added a button to roll back changes to the previous saved state
  • Fixed a bug: when switching the "player", if the "input device" and "controller type" settings were changed, the save dialog box did not appear.
  • "Motion", "Rumble" and "Led" also have events notifying about changes
  • Fixed a bug where the currently selected device would switch to "Disconnected" mode when connecting another controller
  • Profiles are now independent and apply to any controllers.
  • Profiles are selected and show changes (if any) as soon as you switch them.
  • When saving a profile, the profile switches to the newly created one
  • When deleting a profile, it changes the name to the default (previously it still displayed the deleted one), but leaves the changed configuration so that you can save it again under a different name

https://github.com/user-attachments/assets/bd8c7df8-a906-4c67-8a26-3883bfe26af7

** The controller will not be lost if you accidentally turn off the controller and save the configuration. (This does not fix the bug when XBox SeriesX controllers are not restored after rebooting)

I made some fixes to the settings input section. Changes and fixes: - Paired devices have notifications that they are configured and require connection - Paired devices load the configuration when connected - Disconnected but configured controllers wait for connection, displaying the name and device ID. - A notification appears when changing control configuration settings. - Now control settings will be saved only when they are changed ** - Added a button to roll back changes to the previous saved state - Fixed a bug: when switching the "player", if the "input device" and "controller type" settings were changed, the save dialog box did not appear. - "Motion", "Rumble" and "Led" also have events notifying about changes - Fixed a bug where the currently selected device would switch to "Disconnected" mode when connecting another controller - Profiles are now independent and apply to any controllers. - Profiles are selected and show changes (if any) as soon as you switch them. - When saving a profile, the profile switches to the newly created one - When deleting a profile, it changes the name to the default (previously it still displayed the deleted one), but leaves the changed configuration so that you can save it again under a different name https://github.com/user-attachments/assets/bd8c7df8-a906-4c67-8a26-3883bfe26af7 ** The controller will not be lost if you accidentally turn off the controller and save the configuration. (This does not fix the bug when XBox SeriesX controllers are not restored after rebooting)
github-actions[bot] commented 2025-02-23 00:32:12 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+cb0b781-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748576427.zip) * [ryujinx-Release-1.2.0+cb0b781-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748576611.zip) * [ryujinx-Release-1.2.0+cb0b781-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748585505.zip) * [ryujinx-Release-1.2.0+cb0b781-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748585720.zip) * [ryujinx-Release-1.2.0+cb0b781-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748590931.zip) * [ryujinx-Release-1.2.0+cb0b781-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748610165.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+cb0b781-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748577092.zip) * [ryujinx-Debug-1.2.0+cb0b781-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748577318.zip) * [ryujinx-Debug-1.2.0+cb0b781-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748587199.zip) * [ryujinx-Debug-1.2.0+cb0b781-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748590111.zip) * [ryujinx-Debug-1.2.0+cb0b781-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748590292.zip) * [ryujinx-Debug-1.2.0+cb0b781-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2748609051.zip) </details>
bozis92 commented 2025-03-07 11:13:03 +00:00 (Migrated from github.com)
Copy Link

maybe you can add a buttom on motion section to reset motion position?
Sometimes the motion sensor becomes uncalibrated and is not aligned with the center of the screen. A button that resets its position would be nice.

maybe you can add a buttom on motion section to reset motion position? Sometimes the motion sensor becomes uncalibrated and is not aligned with the center of the screen. A button that resets its position would be nice.
Goodfeat commented 2025-03-07 13:07:38 +00:00 (Migrated from github.com)
Copy Link

You probably want me to add a reset button here? But the thing is, I don't use this section and don't know how it works. You can try the undo button next to the "player" line, it undoes everything you've changed

image

You probably want me to add a reset button here? But the thing is, I don't use this section and don't know how it works. You can try the undo button next to the "player" line, it undoes everything you've changed ![image](https://github.com/user-attachments/assets/3be61dfa-153d-4534-afe3-b9e33b188421)
bozis92 commented 2025-03-07 13:14:46 +00:00 (Migrated from github.com)
Copy Link

image
these red squares but they only reset the gyroscope position and do not erase all the settings.

you think its possible?

![image](https://github.com/user-attachments/assets/ffbcce8b-a6e7-4186-8893-1aadb0699346) these red squares but they only reset the gyroscope position and do not erase all the settings. you think its possible?
Goodfeat commented 2025-03-07 13:24:43 +00:00 (Migrated from github.com)
Copy Link

No, there is no stick calibration functionality, and it is not planned in this pull request. Please create a new issue in the appropriate section

No, there is no stick calibration functionality, and it is not planned in this pull request. Please create a new issue in the appropriate section
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Goodfeat/Master_PR:Goodfeat/Master_PR
git checkout Goodfeat/Master_PR
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#708
No description provided.
Delete Branch "Goodfeat/Master_PR"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?