MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Revert "Vulkan: Feedback loop detection and barriers (#7226)" #728

Open
KeatonTheBot wants to merge 2 commits from KeatonTheBot/revert-vulkan-barriers into master
pull from: KeatonTheBot/revert-vulkan-barriers
merge into: MeloNX:master
Conversation 5 Commits 2 Files Changed 16 +57 -508
KeatonTheBot commented 2025-02-26 23:13:16 +00:00 (Migrated from github.com)
Copy Link

This reverts commit ca59c3f499.

Prevents slowdowns in Paper Mario: The Thousand Year Door, the Xenoblade games, and others. Feel free to test and let me know if you get speedups in games where it would normally slow down.

There are known issues with AMD RX 7000 (RDNA 3) cards, so a fix implementing barriers only on these cards would be an ideal solution.

This reverts commit ca59c3f4998e2d1beb3b0d0214611e3332238557. Prevents slowdowns in Paper Mario: The Thousand Year Door, the Xenoblade games, and others. Feel free to test and let me know if you get speedups in games where it would normally slow down. There are known issues with AMD RX 7000 (RDNA 3) cards, so a fix implementing barriers *only* on these cards would be an ideal solution.
github-actions[bot] commented 2025-02-26 23:21:25 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+e714348-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727795542.zip) * [ryujinx-Release-1.2.0+e714348-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727795693.zip) * [ryujinx-Release-1.2.0+e714348-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727801203.zip) * [ryujinx-Release-1.2.0+e714348-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727801358.zip) * [ryujinx-Release-1.2.0+e714348-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727802217.zip) * [ryujinx-Release-1.2.0+e714348-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727815822.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+e714348-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727792770.zip) * [ryujinx-Debug-1.2.0+e714348-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727792875.zip) * [ryujinx-Debug-1.2.0+e714348-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727800675.zip) * [ryujinx-Debug-1.2.0+e714348-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727800816.zip) * [ryujinx-Debug-1.2.0+e714348-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727802033.zip) * [ryujinx-Debug-1.2.0+e714348-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2727810094.zip) </details>
BooBerry commented 2025-03-11 15:06:16 +00:00 (Migrated from github.com)
Copy Link

Really hope there's an option to enable it on demand, as this is needed for me to play Tears of the Kingdom with my AMD RX 7800 XT.

Really hope there's an option to enable it on demand, as this is needed for me to play Tears of the Kingdom with my AMD RX 7800 XT.
GreemDev commented 2025-03-11 16:58:18 +00:00 (Migrated from github.com)
Copy Link

Really hope there's an option to enable it on demand, as this is needed for me to play Tears of the Kingdom with my AMD RX 7800 XT.

There won't be. I tried that already and it's a duplication of 30 thousand lines of code because the Vulkan renderer we have has no abstraction.

> Really hope there's an option to enable it on demand, as this is needed for me to play Tears of the Kingdom with my AMD RX 7800 XT. There won't be. I tried that already and it's a duplication of 30 thousand lines of code because the Vulkan renderer we have has *no* abstraction.
BooBerry commented 2025-03-11 16:59:43 +00:00 (Migrated from github.com)
Copy Link

That's... really unfortunate.

Okay, is there another way to fix it then so it doesn't have graphical glitches for RDNA3 cards?

That's... really unfortunate. Okay, is there another way to fix it then so it doesn't have graphical glitches for RDNA3 cards?
GreemDev commented 2025-03-11 17:08:33 +00:00 (Migrated from github.com)
Copy Link

This PR (or rather, the inverse of it, since this is a revert PR) is what fixed that issue so I'm not sure

This PR (or rather, the inverse of it, since this is a revert PR) is what fixed that issue so I'm not sure
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin KeatonTheBot/revert-vulkan-barriers:KeatonTheBot/revert-vulkan-barriers
git checkout KeatonTheBot/revert-vulkan-barriers
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gpu
graphics-backend:vulkan
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#728
No description provided.
Delete Branch "KeatonTheBot/revert-vulkan-barriers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?