MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues 184 Pull Requests 15 Actions Packages Projects Releases 36 Wiki Activity

Add ability to trim XCI files from the application context menu #52

Closed
amurgshere wants to merge 2 commits from add-ability-to-trim-XCI-files-from-the-application-context-menu into master
pull from: add-ability-to-trim-XCI-files-from-the-application-context-menu
merge into: MeloNX:master
Conversation 4 Commits 2 Files Changed 9 +720 -2
amurgshere commented 2024-10-23 15:26:44 +00:00 (Migrated from github.com)
Copy Link

Right click on any application, if the XCI ROM file can be trimmed then the "Check and Trim XCI File" menu item will be enabled, clicking this menu item will show a dialog confirming that the free space will be scanned to ensure it is safe to trim, if the user clicks OK, the file will be checked and trimmed.

Future implementations could also allow bulk trimming with a new popup dialog to facilitate the user interface.

image
image
image

Right click on any application, if the XCI ROM file can be trimmed then the "Check and Trim XCI File" menu item will be enabled, clicking this menu item will show a dialog confirming that the free space will be scanned to ensure it is safe to trim, if the user clicks OK, the file will be checked and trimmed. Future implementations could also allow bulk trimming with a new popup dialog to facilitate the user interface. ![image](https://github.com/user-attachments/assets/a340780b-1303-4505-82e0-30575ae240b1) ![image](https://github.com/user-attachments/assets/2c7b97a3-cb9e-4c4d-bbb7-e44c3f598fde) ![image](https://github.com/user-attachments/assets/564074df-8491-45d3-b4e7-ff157147a34f)
👍 1
GreemDev (Migrated from github.com) reviewed 2024-10-23 15:30:04 +00:00
src/Ryujinx.Common/Utilities/XCIFileTrimmer.cs
GreemDev (Migrated from github.com) commented 2024-10-23 15:30:04 +00:00
Copy Link

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
github-actions[bot] commented 2024-10-23 15:39:41 +00:00 (Migrated from github.com)
Copy Link

Download the artifacts for this pull request:

GUI-less (SDL2)
Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+014bc0c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094528416.zip) * [ryujinx-Release-1.2.0+014bc0c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094536405.zip) * [ryujinx-Release-1.2.0+014bc0c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094543798.zip) * [ryujinx-Release-1.2.0+014bc0c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094553392.zip) <details><summary>GUI-less (SDL2)</summary> * [sdl2-ryujinx-headless-Release-1.2.0+014bc0c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094528656.zip) * [sdl2-ryujinx-headless-Release-1.2.0+014bc0c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094536667.zip) * [sdl2-ryujinx-headless-Release-1.2.0+014bc0c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094544064.zip) * [sdl2-ryujinx-headless-Release-1.2.0+014bc0c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094553707.zip) </details> <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+014bc0c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094528481.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+014bc0c-linux_arm64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094528725.zip) * [ryujinx-Debug-1.2.0+014bc0c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094538296.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+014bc0c-linux_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094538462.zip) * [ryujinx-Debug-1.2.0+014bc0c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094545464.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+014bc0c-macos_universal](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094545641.zip) * [ryujinx-Debug-1.2.0+014bc0c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094555731.zip) * [sdl2-ryujinx-headless-Debug-1.2.0+014bc0c-win_x64](https://nightly.link/GreemDev/Ryujinx/actions/artifacts/2094556046.zip) </details>
amurgshere (Migrated from github.com) reviewed 2024-10-23 15:52:49 +00:00
src/Ryujinx.Common/Utilities/XCIFileTrimmer.cs
amurgshere (Migrated from github.com) commented 2024-10-23 15:52:49 +00:00
Copy Link

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
amurgshere commented 2024-10-29 16:10:45 +00:00 (Migrated from github.com)
Copy Link

Closed, as this is replaced by https://github.com/GreemDev/Ryujinx/pull/105

Closed, as this is replaced by https://github.com/GreemDev/Ryujinx/pull/105

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
audio
Affects Audio playback during emulation
blocked on external progress
This cannot move forward without work on an external project or service.
bug
Something isn't working
cpu
An issue with ARMeilleure, the JIT, or Hypervisor
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good first issues to work on for new contributors
gpu
Affects GPU emulation
graphics-backend:metal
Affects the Metal Graphics backend
graphics-backend:opengl
Affects the OpenGL Graphics backend
graphics-backend:vulkan
Affects the Vulkan Graphics backend
gui
Affects the Avalonia UI or translations.
help wanted
Extra attention is needed
horizon
Affects the Horizon OS HLE components.
infra
Updates to dependencies
invalid
This doesn't seem right
kernel
Affects the kernel HLE components.
ldn
Affects the LDN functionality
linux
Linux only issue
macOS
macOS only issue
not planned but open to a PR
I do not intend on working on this myself, but I would not be opposed to an implementation.
question
Further information is requested
windows
Windows only issue
wontfix
This will not be worked on
No Label
gui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#52
No description provided.
Delete Branch "add-ability-to-trim-XCI-files-from-the-application-context-menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?