Add ability to trim XCI files from the application context menu #52

Closed
amurgshere wants to merge 2 commits from add-ability-to-trim-XCI-files-from-the-application-context-menu into master
9 changed files with 720 additions and 2 deletions

View File

@ -72,5 +72,6 @@ namespace Ryujinx.Common.Logging
TamperMachine,
UI,
Vic,
XCIFileTrimmer
}
}

View File

@ -0,0 +1,30 @@
using Ryujinx.Common.Utilities;
namespace Ryujinx.Common.Logging
{
public class XCIFileTrimmerLog : XCIFileTrimmer.ILog
{
public virtual void Progress(long current, long total, string text, bool complete)
{
}
public void Write(XCIFileTrimmer.LogType logType, string text)
{
switch (logType)
{
case XCIFileTrimmer.LogType.Info:
Logger.Notice.Print(LogClass.XCIFileTrimmer, text);
break;
case XCIFileTrimmer.LogType.Warn:
Logger.Warning?.Print(LogClass.XCIFileTrimmer, text);
break;
case XCIFileTrimmer.LogType.Error:
Logger.Error?.Print(LogClass.XCIFileTrimmer, text);
break;
case XCIFileTrimmer.LogType.Progress:
Logger.Info?.Print(LogClass.XCIFileTrimmer, text);
break;
}
}
}
}

View File

@ -0,0 +1,487 @@
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using Gommon;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using System;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using System.Collections.Generic;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using System.Diagnostics;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using System.IO;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
using System.Linq;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
namespace Ryujinx.Common.Utilities
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public sealed class XCIFileTrimmer
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const long BytesInAMegabyte = 1024 * 1024;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const int BufferSize = 8 * (int)BytesInAMegabyte;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const long CartSizeMBinFormattedGB = 952;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const int CartKeyAreaSize = 0x1000;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const byte PaddingByte = 0xFF;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const int HeaderFilePos = 0x100;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const int CartSizeFilePos = 0x10D;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const int DataSizeFilePos = 0x118;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private const string HeaderMagicValue = "HEAD";
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
/// <summary>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
/// Cartridge Sizes (ByteIdentifier, SizeInGB)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
/// </summary>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private static readonly Dictionary<byte, long> _cartSizesGB = new()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{ 0xFA, 1 },
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{ 0xF8, 2 },
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{ 0xF0, 4 },
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{ 0xE0, 8 },
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{ 0xE1, 16 },
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{ 0xE2, 32 }
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
};
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private static long RecordsToByte(long records)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return 512 + (records * 512);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public static bool CanTrim(string filename, ILog log = null)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (Path.GetExtension(filename).Equals(".XCI", StringComparison.InvariantCultureIgnoreCase))
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var trimmer = new XCIFileTrimmer(filename, log);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return trimmer.CanBeTrimmed;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public static bool CanUntrim(string filename, ILog log = null)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (Path.GetExtension(filename).Equals(".XCI", StringComparison.InvariantCultureIgnoreCase))
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var trimmer = new XCIFileTrimmer(filename, log);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return trimmer.CanBeUntrimmed;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private ILog _log;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private string _filename;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private FileStream _fileStream;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private BinaryReader _binaryReader;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private long _offsetB, _dataSizeB, _cartSizeB, _fileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private bool _fileOK = true;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private bool _freeSpaceChecked = false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private bool _freeSpaceValid = false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public enum OperationOutcome
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
InvalidXCIFile,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
NoTrimNecessary,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
NoUntrimPossible,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
FreeSpaceCheckFailed,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
FileIOWriteError,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
ReadOnlyFileCannotFix,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
FileSizeChanged,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Successful
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public enum LogType
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Info,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Warn,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Error,
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Progress
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public interface ILog
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public void Write(LogType logType, string text);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public void Progress(long current, long total, string text, bool complete);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public bool FileOK => _fileOK;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public bool Trimmed => _fileOK && FileSizeB < UntrimmedFileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public bool ContainsKeyArea => _offsetB != 0;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public bool CanBeTrimmed => _fileOK && FileSizeB > TrimmedFileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public bool CanBeUntrimmed => _fileOK && FileSizeB < UntrimmedFileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public bool FreeSpaceChecked => _fileOK && _freeSpaceChecked;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public bool FreeSpaceValid => _fileOK && _freeSpaceValid;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long DataSizeB => _dataSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long CartSizeB => _cartSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long FileSizeB => _fileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long DiskSpaceSavedB => CartSizeB - FileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long DiskSpaceSavingsB => CartSizeB - DataSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long TrimmedFileSizeB => _offsetB + _dataSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long UntrimmedFileSizeB => _offsetB + _cartSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public ILog Log
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
get => _log;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
set => _log = value;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public String Filename
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
get => _filename;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
set
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_filename = value;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Reset();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public long Pos
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
get => _fileStream.Position;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
set => _fileStream.Position = value;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public XCIFileTrimmer(string path, ILog log = null)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log = log;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Filename = path;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
ReadHeader();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public void CheckFreeSpace()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (FreeSpaceChecked)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (CanBeTrimmed)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_freeSpaceValid = false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
OpenReaders();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Pos = TrimmedFileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
bool freeSpaceValid = true;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long readSizeB = FileSizeB - TrimmedFileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Stopwatch timedSw = Lambda.Timed(() =>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
freeSpaceValid = CheckPadding(readSizeB);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
});
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (timedSw.Elapsed.TotalSeconds > 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, $"Checked at {readSizeB / (double)XCIFileTrimmer.BytesInAMegabyte / timedSw.Elapsed.TotalSeconds:N} Mb/sec");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (freeSpaceValid)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, "Free space is valid");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_freeSpaceValid = freeSpaceValid;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
finally
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
CloseReaders();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
else
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Warn, "There is no free space to check.");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_freeSpaceValid = false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
finally
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_freeSpaceChecked = true;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private bool CheckPadding(long readSizeB)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long maxReads = readSizeB / XCIFileTrimmer.BufferSize;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long read = 0;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var buffer = new byte[BufferSize];
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
while (true)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
int bytes = _fileStream.Read(buffer, 0, XCIFileTrimmer.BufferSize);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (bytes == 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
break;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Progress(read, maxReads, "Verifying file can be trimmed", false);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (buffer.Take(bytes).AsParallel().Any(b => b != XCIFileTrimmer.PaddingByte))
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Warn, "Free space is NOT valid");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
read++;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return true;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private void Reset()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_freeSpaceChecked = false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_freeSpaceValid = false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
ReadHeader();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public OperationOutcome Trim()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!FileOK)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.InvalidXCIFile;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!CanBeTrimmed)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.NoTrimNecessary;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!FreeSpaceChecked)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
CheckFreeSpace();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!FreeSpaceValid)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.FreeSpaceCheckFailed;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, "Trimming...");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var info = new FileInfo(Filename);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if ((info.Attributes & FileAttributes.ReadOnly) == FileAttributes.ReadOnly)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, "Attempting to remove ReadOnly attribute");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
File.SetAttributes(Filename, info.Attributes & ~FileAttributes.ReadOnly);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
catch (Exception e)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, e.ToString());
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.ReadOnlyFileCannotFix;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (info.Length != FileSizeB)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, "File size has changed, cannot safely trim.");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.FileSizeChanged;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var outfileStream = new FileStream(_filename, FileMode.Open, FileAccess.Write, FileShare.Write);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
outfileStream.SetLength(TrimmedFileSizeB);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.Successful;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
finally
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
outfileStream.Close();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Reset();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
catch (Exception e)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, e.ToString());
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.FileIOWriteError;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
public OperationOutcome Untrim()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!FileOK)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.InvalidXCIFile;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!CanBeUntrimmed)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.NoUntrimPossible;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, "Untrimming...");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var info = new FileInfo(Filename);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if ((info.Attributes & FileAttributes.ReadOnly) == FileAttributes.ReadOnly)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, "Attempting to remove ReadOnly attribute");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
File.SetAttributes(Filename, info.Attributes & ~FileAttributes.ReadOnly);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
catch (Exception e)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, e.ToString());
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.ReadOnlyFileCannotFix;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (info.Length != FileSizeB)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, "File size has changed, cannot safely untrim.");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.FileSizeChanged;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var outfileStream = new FileStream(_filename, FileMode.Append, FileAccess.Write, FileShare.Write);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long bytesToWriteB = UntrimmedFileSizeB - FileSizeB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Stopwatch timedSw = Lambda.Timed(() =>
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
WritePadding(outfileStream, bytesToWriteB);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
});
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (timedSw.Elapsed.TotalSeconds > 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Info, $"Wrote at {bytesToWriteB / (double)XCIFileTrimmer.BytesInAMegabyte / timedSw.Elapsed.TotalSeconds:N} Mb/sec");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.Successful;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
finally
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
outfileStream.Close();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Reset();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
catch (Exception e)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, e.ToString());
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return OperationOutcome.FileIOWriteError;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private void WritePadding(FileStream outfileStream, long bytesToWriteB)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long bytesLeftToWriteB = bytesToWriteB;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long writes = bytesLeftToWriteB / XCIFileTrimmer.BufferSize;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
int write = 0;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
var buffer = new byte[BufferSize];
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Array.Fill<byte>(buffer, XCIFileTrimmer.PaddingByte);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
while (bytesLeftToWriteB > 0)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long bytesToWrite = Math.Min(XCIFileTrimmer.BufferSize, bytesLeftToWriteB);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
outfileStream.Write(buffer, 0, (int)bytesToWrite);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
bytesLeftToWriteB -= bytesToWrite;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Progress(write, writes, "Writing padding data...", false);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
write++;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
finally
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Progress(write, writes, "Writing padding data...", true);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private void OpenReaders()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (_binaryReader == null)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_fileStream = new FileStream(_filename, FileMode.Open, FileAccess.Read, FileShare.Read);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_binaryReader = new BinaryReader(_fileStream);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private void CloseReaders()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (_binaryReader != null && _binaryReader.BaseStream != null)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_binaryReader.Close();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_binaryReader = null;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_fileStream = null;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GC.Collect();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private void ReadHeader()
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
OpenReaders();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
try
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
// Attempt without key area
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
bool success = CheckAndReadHeader(false);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!success)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
// Attempt with key area
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
success = CheckAndReadHeader(true);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_fileOK = success;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
finally
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
CloseReaders();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
catch (Exception ex)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, ex.Message);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_fileOK = false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_dataSizeB = 0;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_cartSizeB = 0;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_fileSizeB = 0;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_offsetB = 0;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
private bool CheckAndReadHeader(bool assumeKeyArea)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
// Read file size
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_fileSizeB = _fileStream.Length;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (_fileSizeB < 32 * 1024)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, "The source file doesn't look like an XCI file as the data size is too small");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
// Setup offset
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_offsetB = (long)(assumeKeyArea ? XCIFileTrimmer.CartKeyAreaSize : 0);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
// Check header
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Pos = _offsetB + XCIFileTrimmer.HeaderFilePos;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
string head = System.Text.Encoding.ASCII.GetString(_binaryReader.ReadBytes(4));
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (head != XCIFileTrimmer.HeaderMagicValue)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!assumeKeyArea)
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Warn, $"Incorrect header found, file mat contain a key area...");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
else
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, "The source file doesn't look like an XCI file as the header is corrupted");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
// Read Cart Size
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Pos = _offsetB + XCIFileTrimmer.CartSizeFilePos;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
byte cartSizeId = _binaryReader.ReadByte();
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
if (!_cartSizesGB.TryGetValue(cartSizeId, out long cartSizeNGB))
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
{
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Log?.Write(LogType.Error, $"The source file doesn't look like an XCI file as the Cartridge Size is incorrect (0x{cartSizeId:X2})");
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return false;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_cartSizeB = cartSizeNGB * XCIFileTrimmer.CartSizeMBinFormattedGB * XCIFileTrimmer.BytesInAMegabyte;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
// Read data size
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
Pos = _offsetB + XCIFileTrimmer.DataSizeFilePos;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
long records = (long)BitConverter.ToUInt32(_binaryReader.ReadBytes(4), 0);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
_dataSizeB = RecordsToByte(records);
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
return true;
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.
}
GreemDev commented 2024-10-23 15:30:04 +00:00 (Migrated from github.com)
Review

This function can be entirely replaced with Lambda.Timed(Action), from my common library Gommon (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.

This function can be entirely replaced with `Lambda.Timed(Action)`, from my common library `Gommon` (which is already referenced by this Ryujinx fork). The only difference is that Timed returns the stopwatch directly instead of its Elapsed property.
amurgshere commented 2024-10-23 15:52:49 +00:00 (Migrated from github.com)
Review

Thanks @GreemDev ,

I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

Thanks @GreemDev , I have updated the branch with your suggested changes, definitely don't want to duplicate any code.

View File

@ -84,8 +84,11 @@
"GameListContextMenuOpenModsDirectoryToolTip": "Opens the directory which contains Application's Mods",
"GameListContextMenuOpenSdModsDirectory": "Open Atmosphere Mods Directory",
"GameListContextMenuOpenSdModsDirectoryToolTip": "Opens the alternative SD card Atmosphere directory which contains Application's Mods. Useful for mods that are packaged for real hardware.",
"GameListContextMenuTrimXCI": "Check and Trim XCI File",
"GameListContextMenuTrimXCIToolTip": "Check and Trim XCI File to Save Disk Space",
"StatusBarGamesLoaded": "{0}/{1} Games Loaded",
"StatusBarSystemVersion": "System Version: {0}",
"StatusBarXCIFileTrimming": "Trimming XCI File '{0}'",
"LinuxVmMaxMapCountDialogTitle": "Low limit for memory mappings detected",
"LinuxVmMaxMapCountDialogTextPrimary": "Would you like to increase the value of vm.max_map_count to {0}",
"LinuxVmMaxMapCountDialogTextSecondary": "Some games might try to create more memory mappings than currently allowed. Ryujinx will crash as soon as this limit gets exceeded.",
@ -718,6 +721,16 @@
"SelectDlcDialogTitle": "Select DLC files",
"SelectUpdateDialogTitle": "Select update files",
"SelectModDialogTitle": "Select mod directory",
"TrimXCIFileDialogTitle": "Check and Trim XCI File",
"TrimXCIFileDialogPrimaryText": "This function will first check the empty space and then trim the XCI File to save disk space.",
"TrimXCIFileDialogSecondaryText": "Current File Size: {0:n} MB\nGame Data Size: {1:n} MB\nDisk Space Savings: {2:n} MB",
"TrimXCIFileNoTrimNecessary": "XCI File does not need to be trimmed. Check logs for further details",
"TrimXCIFileReadOnlyFileCannotFix": "XCI File is Read Only and could not be made writable. Check logs for further details",
"TrimXCIFileFileSizeChanged": "XCI File has changed in size since it was scanned. Please check the file is not being written to and try again.",
"TrimXCIFileFreeSpaceCheckFailed": "XCI File has data in the free space area, it is not safe to trim",
"TrimXCIFileInvalidXCIFile": "XCI File contains invalid data. Check logs for further details",
"TrimXCIFileFileIOWriteError": "XCI File could not be opened for writing. Check logs for further details",
"TrimXCIFileFailedPrimaryText": "Trimming of the XCI file failed",
"UserProfileWindowTitle": "User Profiles Manager",
"CheatWindowTitle": "Cheats Manager",
"DlcWindowTitle": "Manage Downloadable Content for {0} ({1})",
@ -735,6 +748,7 @@
"AutoloadDlcAndUpdateAddedMessage": "{0} new downloadable content(s) and {1} new update(s) added",
"ModWindowHeading": "{0} Mod(s)",
"UserProfilesEditProfile": "Edit Selected",
"Continue": "Continue",
"Cancel": "Cancel",
"Save": "Save",
"Discard": "Discard",

View File

@ -0,0 +1,24 @@
using Ryujinx.Ava.UI.ViewModels;
namespace Ryujinx.Ava.Common
{
internal class XCIFileTrimmerLog : Ryujinx.Common.Logging.XCIFileTrimmerLog
{
private readonly MainWindowViewModel _viewModel;
public XCIFileTrimmerLog(MainWindowViewModel viewModel)
{
_viewModel = viewModel;
}
public override void Progress(long current, long total, string text, bool complete)
{
Avalonia.Threading.Dispatcher.UIThread.Post(() =>
{
_viewModel.StatusBarProgressMaximum = (int)(total);
_viewModel.StatusBarProgressValue = (int)(current);
});
}
}
}

View File

@ -70,6 +70,12 @@
Header="{locale:Locale GameListContextMenuOpenSdModsDirectory}"
Icon="{icon:Icon mdi-folder-file}"
ToolTip.Tip="{locale:Locale GameListContextMenuOpenSdModsDirectoryToolTip}" />
<Separator />
<MenuItem
Click="TrimXCI_Click"
Header="{locale:Locale GameListContextMenuTrimXCI}"
IsEnabled="{Binding TrimXCIEnabled}"
ToolTip.Tip="{locale:Locale GameListContextMenuTrimXCIToolTip}" />
<Separator />
<MenuItem Header="{locale:Locale GameListContextMenuCacheManagement}" Icon="{icon:Icon mdi-cached}">
<MenuItem

View File

@ -2,6 +2,7 @@ using Avalonia.Controls;
using Avalonia.Interactivity;
using Avalonia.Markup.Xaml;
using Avalonia.Platform.Storage;
using Avalonia.Threading;
using LibHac.Fs;
using LibHac.Tools.FsSystem.NcaUtils;
using Ryujinx.Ava.Common;
@ -17,6 +18,8 @@ using SkiaSharp;
using System;
using System.Collections.Generic;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Path = System.IO.Path;
namespace Ryujinx.Ava.UI.Controls
@ -323,5 +326,15 @@ namespace Ryujinx.Ava.UI.Controls
if (sender is MenuItem { DataContext: MainWindowViewModel { SelectedApplication: not null } viewModel })
await viewModel.LoadApplication(viewModel.SelectedApplication);
}
public async void TrimXCI_Click(object sender, RoutedEventArgs args)
{
var viewModel = (sender as MenuItem)?.DataContext as MainWindowViewModel;
if (viewModel?.SelectedApplication != null)
{
await viewModel.TrimXCIFile(viewModel.SelectedApplication.Path);
}
}
}
}

View File

@ -21,6 +21,7 @@ using Ryujinx.Ava.UI.Windows;
using Ryujinx.Common;
using Ryujinx.Common.Configuration;
using Ryujinx.Common.Logging;
using Ryujinx.Common.Utilities;
using Ryujinx.Cpu;
using Ryujinx.HLE;
using Ryujinx.HLE.FileSystem;
@ -37,6 +38,7 @@ using SkiaSharp;
using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.ComponentModel;
using System.Globalization;
using System.IO;
using System.Linq;
@ -80,6 +82,8 @@ namespace Ryujinx.Ava.UI.ViewModels
private bool _isAppletMenuActive;
private int _statusBarProgressMaximum;
private int _statusBarProgressValue;
private string _statusBarProgressStatusText;
private bool _statusBarProgressStatusVisible;
private bool _isPaused;
private bool _showContent = true;
private bool _isLoadingIndeterminate = true;
@ -371,6 +375,8 @@ namespace Ryujinx.Ava.UI.ViewModels
public bool OpenDeviceSaveDirectoryEnabled => !SelectedApplication.ControlHolder.ByteSpan.IsZeros() && SelectedApplication.ControlHolder.Value.DeviceSaveDataSize > 0;
public bool TrimXCIEnabled => Ryujinx.Common.Utilities.XCIFileTrimmer.CanTrim(SelectedApplication.Path, new Common.XCIFileTrimmerLog(this));
public bool OpenBcatSaveDirectoryEnabled => !SelectedApplication.ControlHolder.ByteSpan.IsZeros() && SelectedApplication.ControlHolder.Value.BcatDeliveryCacheStorageSize > 0;
public bool CreateShortcutEnabled => !ReleaseInformation.IsFlatHubBuild;
@ -485,6 +491,28 @@ namespace Ryujinx.Ava.UI.ViewModels
}
}
public bool StatusBarProgressStatusVisible
{
get => _statusBarProgressStatusVisible;
set
{
_statusBarProgressStatusVisible = value;
OnPropertyChanged();
}
}
public string StatusBarProgressStatusText
{
get => _statusBarProgressStatusText;
set
{
_statusBarProgressStatusText = value;
OnPropertyChanged();
}
}
public string FifoStatusText
{
get => _fifoStatusText;
@ -1802,6 +1830,114 @@ namespace Ryujinx.Ava.UI.ViewModels
}
}
}
public async void ProcessTrimResult(String filename, Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome operationOutcome)
{
string notifyUser = null;
switch (operationOutcome)
{
case Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome.NoTrimNecessary:
notifyUser = LocaleManager.Instance[LocaleKeys.TrimXCIFileNoTrimNecessary];
break;
case Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome.ReadOnlyFileCannotFix:
notifyUser = LocaleManager.Instance[LocaleKeys.TrimXCIFileReadOnlyFileCannotFix];
break;
case Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome.FreeSpaceCheckFailed:
notifyUser = LocaleManager.Instance[LocaleKeys.TrimXCIFileFreeSpaceCheckFailed];
break;
case Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome.InvalidXCIFile:
notifyUser = LocaleManager.Instance[LocaleKeys.TrimXCIFileInvalidXCIFile];
break;
case Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome.FileIOWriteError:
notifyUser = LocaleManager.Instance[LocaleKeys.TrimXCIFileFileIOWriteError];
break;
case Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome.FileSizeChanged:
notifyUser = LocaleManager.Instance[LocaleKeys.TrimXCIFileFileSizeChanged];
break;
case Ryujinx.Common.Utilities.XCIFileTrimmer.OperationOutcome.Successful:
if (Avalonia.Application.Current.ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktop)
{
if (desktop.MainWindow is MainWindow mainWindow)
mainWindow.LoadApplications();
}
break;
}
if (notifyUser != null)
{
await ContentDialogHelper.CreateWarningDialog(
LocaleManager.Instance[LocaleKeys.TrimXCIFileFailedPrimaryText],
notifyUser
);
}
}
public async Task TrimXCIFile(string filename)
{
if (filename == null)
{
return;
}
var trimmer = new XCIFileTrimmer(filename, new Common.XCIFileTrimmerLog(this));
if (trimmer.CanBeTrimmed)
{
var savings = (double)trimmer.DiskSpaceSavingsB / 1024.0 / 1024.0;
var currentFileSize = (double)trimmer.FileSizeB / 1024.0 / 1024.0;
var cartDataSize = (double)trimmer.DataSizeB / 1024.0 / 1024.0;
string secondaryText = LocaleManager.Instance.UpdateAndGetDynamicValue(LocaleKeys.TrimXCIFileDialogSecondaryText, currentFileSize, cartDataSize, savings);
var result = await ContentDialogHelper.CreateConfirmationDialog(
LocaleManager.Instance[LocaleKeys.TrimXCIFileDialogPrimaryText],
secondaryText,
LocaleManager.Instance[LocaleKeys.Continue],
LocaleManager.Instance[LocaleKeys.Cancel],
LocaleManager.Instance[LocaleKeys.TrimXCIFileDialogTitle]
);
if (result == UserResult.Yes)
{
Thread XCIFileTrimThread = new(() =>
{
Dispatcher.UIThread.Post(() =>
{
StatusBarProgressStatusText = LocaleManager.Instance.UpdateAndGetDynamicValue(LocaleKeys.StatusBarXCIFileTrimming, Path.GetFileName(filename));
StatusBarProgressStatusVisible = true;
StatusBarProgressMaximum = 1;
StatusBarProgressValue = 0;
StatusBarVisible = true;
});
try
{
XCIFileTrimmer.OperationOutcome operationOutcome = trimmer.Trim();
Dispatcher.UIThread.Post(() =>
{
ProcessTrimResult(filename, operationOutcome);
});
}
finally
{
Dispatcher.UIThread.Post(() =>
{
StatusBarProgressStatusVisible = false;
StatusBarProgressStatusText = string.Empty;
StatusBarVisible = false;
});
}
})
{
Name = "GUI.XCFileTrimmerThread",
IsBackground = true,
};
XCIFileTrimThread.Start();
}
}
}
#endregion
}
}

View File

@ -29,7 +29,7 @@
Margin="5"
VerticalAlignment="Center"
IsVisible="{Binding EnableNonGameRunningControls}">
<Grid Margin="0" ColumnDefinitions="Auto,Auto,*">
<Grid Margin="0" ColumnDefinitions="Auto,Auto,Auto,*">
<Button
Width="25"
Height="25"
@ -50,9 +50,16 @@
VerticalAlignment="Center"
IsVisible="{Binding EnableNonGameRunningControls}"
Text="{locale:Locale StatusBarGamesLoaded}" />
<TextBlock
Name="StatusBarProgressStatus"
Grid.Column="2"
Margin="10,0,5,0"
VerticalAlignment="Center"
IsVisible="{Binding StatusBarProgressStatusVisible}"
Text="{Binding StatusBarProgressStatusText}" />
<ProgressBar
Name="LoadProgressBar"
Grid.Column="2"
Grid.Column="3"
Height="6"
VerticalAlignment="Center"
Foreground="{DynamicResource SystemAccentColorLight2}"