MeloNX/Ryujinx-ryubing
10
0
Fork 0
Code Issues184 Pull Requests15 Actions Packages Projects Releases36 Wiki Activity

WIP: Add TickSource-based turbo mode #747

Draft
GreemDev wants to merge 13 commits from feature/turbo-mode into master
Conversation 3 Commits 13 Files Changed 23 +475 -41
GreemDev commented 2025-03-04 00:45:21 +00:00 (Migrated from github.com)

This PR adds a hotkey that, while held, toggles on a "turbo mode" flag that multiplies elapsed CPU TickSource ticks, which should speed up any games that use delta time between frames for physics calculations.

This is functionally distinct from the existing custom refresh rate, despite sounding similar.
Custom Refresh Rate () simply allows you to increase the emulated Switch's present rate.
This PR actively changes CPU tick speeds by an arbitrary scalar to speed up gameplay deliberately.
The point of CRR () is for more broad FPS cap selection, for games that aren't FPS sensitive.
Alternatively, the point of this PR is to speed up gameplay by an arbitrary factor.

Original PR archive (originally by @nico-abram)
https://web.archive.org/web/20240713135029/https://github.com/Ryujinx/Ryujinx/pull/6456

This todo is written from their perspective; not mine.

TODO:

  • TickSource currently stores the multiplier as a public static. Is this alright, or should it be turned into a private static and a method added? Changed to an instance field.
  • Should the multiplier setting go in System settings? (It's where it's currently at) Moved to CPU
  • Keyboard hotkeys cannot be assigned to a controller. Should the hotkey instead be in the input config?
  • It's implemented as a "Hold" button. Did not see any such buttons in the avalonia UI (Only "toggle on press" buttons) so the way this was implemented might be a bit hacky, It checks IsPressed whenever (currentHotkeyState != _prevHotkeyState) and if it differs from turboMode it updates the multiplier.
  • Need to define a default hotkey. I set it to F3 but didn't think much about it. Unbounded.
  • I set the interval for the setting to [50, 500]%, might need some discussion around what this should be ("What are reasonable values")
  • riperi mentioned on discord that "if this is added, it should also increase the vsync rate". I tried adjusting _ticksPerFrame in SurfaceFlinger.cs, but the game I've been testing on (Xenoblade DE, 30fps game, unmodded) was getting FPS over 30 with VSync on even without modifying that.
This PR adds a hotkey that, while held, toggles on a "turbo mode" flag that multiplies elapsed CPU TickSource ticks, which should speed up any games that use delta time between frames for physics calculations. This is functionally distinct from the existing custom refresh rate, despite sounding similar. Custom Refresh Rate (#238) simply allows you to increase the emulated Switch's present rate. This PR actively changes CPU tick speeds by an arbitrary scalar to speed up gameplay deliberately. The point of CRR (#238) is for more broad FPS cap selection, for games that aren't FPS sensitive. Alternatively, the point of this PR is to speed up gameplay by an arbitrary factor. Original PR archive (originally by @nico-abram) https://web.archive.org/web/20240713135029/https://github.com/Ryujinx/Ryujinx/pull/6456 This todo is written from their perspective; not mine. TODO: - ~~TickSource currently stores the multiplier as a public static. Is this alright, or should it be turned into a private static and a method added?~~ Changed to an instance field. - ~~Should the multiplier setting go in System settings? (It's where it's currently at)~~ Moved to CPU - ~~Keyboard hotkeys cannot be assigned to a controller. Should the hotkey instead be in the input config?~~ - ~~It's implemented as a "Hold" button. Did not see any such buttons in the avalonia UI (Only "toggle on press" buttons) so the way this was implemented might be a bit hacky, It checks IsPressed whenever (currentHotkeyState != _prevHotkeyState) and if it differs from turboMode it updates the multiplier.~~ - ~~Need to define a default hotkey. I set it to F3 but didn't think much about it.~~ Unbounded. - I set the interval for the setting to [50, 500]%, might need some discussion around what this should be ("What are reasonable values") - riperi mentioned on discord that "if this is added, it should also increase the vsync rate". I tried adjusting _ticksPerFrame in SurfaceFlinger.cs, but the game I've been testing on (Xenoblade DE, 30fps game, unmodded) was getting FPS over 30 with VSync on even without modifying that.
👍 1
github-actions[bot] commented 2025-03-04 00:54:02 +00:00 (Migrated from github.com)

Download the artifacts for this pull request:

Only for Developers
Download the artifacts for this pull request: * [ryujinx-Release-1.2.0+7770b7c-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740169139.zip) * [ryujinx-Release-1.2.0+7770b7c-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740169359.zip) * [ryujinx-Release-1.2.0+7770b7c-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740178718.zip) * [ryujinx-Release-1.2.0+7770b7c-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740178930.zip) * [ryujinx-Release-1.2.0+7770b7c-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740179158.zip) * [ryujinx-Release-1.2.0+7770b7c-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740202129.zip) <details><summary>Only for Developers</summary> * [ryujinx-Debug-1.2.0+7770b7c-linux_arm64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740169961.zip) * [ryujinx-Debug-1.2.0+7770b7c-linux_arm64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740170147.zip) * [ryujinx-Debug-1.2.0+7770b7c-linux_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740183148.zip) * [ryujinx-Debug-1.2.0+7770b7c-linux_x64-AppImage](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740183358.zip) * [ryujinx-Debug-1.2.0+7770b7c-macos_universal](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740186360.zip) * [ryujinx-Debug-1.2.0+7770b7c-win_x64](https://nightly.link/Ryubing/Ryujinx/actions/artifacts/2740209188.zip) </details>
amayra commented 2025-03-04 01:47:06 +00:00 (Migrated from github.com)

Would it be possible to add a toggle option for 'turbo mode' so that pressing the assigned hotkey once enables it, and pressing it again disables it? Holding the button is fine for short bursts, but a toggle would make it easier to use for extended periods.

ps: this will be useful in turn-based games

Would it be possible to add a toggle option for 'turbo mode' so that pressing the assigned hotkey once enables it, and pressing it again disables it? Holding the button is fine for short bursts, but a toggle would make it easier to use for extended periods. ps: this will be useful in turn-based games
GreemDev commented 2025-03-04 02:53:15 +00:00 (Migrated from github.com)

Would it be possible to add a toggle option for 'turbo mode' so that pressing the assigned hotkey once enables it, and pressing it again disables it? Holding the button is fine for short bursts, but a toggle would make it easier to use for extended periods.

ps: this will be useful in turn-based games

Please try these PRs before you suggest new things be added.
This is literally already a part of this PR. In fact its the only entry in Keyboard Hotkeys settings that has a "only while pressed" option, allowing you to choose turbo activation type.

> Would it be possible to add a toggle option for 'turbo mode' so that pressing the assigned hotkey once enables it, and pressing it again disables it? Holding the button is fine for short bursts, but a toggle would make it easier to use for extended periods. > > ps: this will be useful in turn-based games Please try these PRs before you suggest new things be added. This is literally already a part of this PR. In fact its the only entry in Keyboard Hotkeys settings that has a "only while pressed" option, allowing you to choose turbo activation type.
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/turbo-mode:feature/turbo-mode
git checkout feature/turbo-mode
Sign in to join this conversation.
No Reviewers
No Label
cpu
gpu
gui
horizon
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MeloNX/Ryujinx-ryubing#747
No description provided.
Delete Branch "feature/turbo-mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?